Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for merging based on login field #2

Open
flowirtz opened this issue Jul 15, 2020 · 0 comments
Open

Add support for merging based on login field #2

flowirtz opened this issue Jul 15, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@flowirtz
Copy link
Contributor

As per all-contributors/all-contributors#416 (comment) we should be able to merge based on the login field instead. This should always be there and be unique, while profile may not be unique.

We should add an input parameter that lets the user decide what field should be merged on.
We should also add that to the docs and reference the above discussion to highlight what advantages/disadvantages each approach has.

@flowirtz flowirtz added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant