Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #66

Open
peterdudfield opened this issue Jun 18, 2024 · 3 comments
Open

Fix tests #66

peterdudfield opened this issue Jun 18, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@peterdudfield
Copy link
Contributor

The CI tests are currently failing, it would be great to get these working again

@peterdudfield peterdudfield added bug Something isn't working good first issue Good for newcomers labels Jun 18, 2024
@jramosss
Copy link

Hey there, i see that the last failing pipeline shows that ruff is failing, and i see there are tons of errors
see here
Is the pipeline expected to fail when not meeting this requirements, should the "real issue" be fix formatting or maybe loose the rules a little bit?

@peterdudfield
Copy link
Contributor Author

yea, perhaps it is to fix the formatting. What do you think should be done? Fix formatting or loosen the rules?

@jramosss
Copy link

jramosss commented Jul 3, 2024

First of all maybe change the name of the issue to fix formatting issues.
Then, definitely loosen the rules, unless the philosophy of the repo is to use docstring (maybe in core/big functions helps, but i don't think every function should have a docstring)
I created a new one, see #67

@peterdudfield peterdudfield changed the title Fix tests Fix liniting Jul 4, 2024
@peterdudfield peterdudfield changed the title Fix liniting Fix tests Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants