From 1b4e8d687ce23e537a3bcdaeef6226b577439af9 Mon Sep 17 00:00:00 2001
From: devsjc <47188100+devsjc@users.noreply.github.com>
Date: Thu, 9 Nov 2023 17:31:55 +0000
Subject: [PATCH] Add validation on ecs task size variable (#326)

---
 .../services/nwp_consumer/variables.tf        | 46 ++++++++++++++++++-
 1 file changed, 45 insertions(+), 1 deletion(-)

diff --git a/terraform/modules/services/nwp_consumer/variables.tf b/terraform/modules/services/nwp_consumer/variables.tf
index 8dab6d17..d3c426dc 100644
--- a/terraform/modules/services/nwp_consumer/variables.tf
+++ b/terraform/modules/services/nwp_consumer/variables.tf
@@ -86,6 +86,50 @@ variable ecs-task_type {
   default = "task"
 }
 
+variable ecs-task_size {
+
+  type = object({
+    cpu = number
+    memory = number
+  })
+
+  description = <<EOT
+    ecs-task_size = {
+      cpu : "CPU units for the ECS task"
+      memory : "Memory units (MB) for the ECS task"
+    }
+    ecs-task_size: "Size of the ECS task in terms of compute and memory"
+  EOT
+
+  default = {
+    cpu = 1024
+    memory = 5120
+  }
+  
+  validation {
+    condition = length(keys(var.ecs-task_size)) == 2
+    error_message = "Variable ecs-task_size must have exactly two keys: cpu and memory."
+  }
+  validation {
+    condition = contains([256, 512, 1024, 2048, 4096, 8192], var.ecs-task_size.cpu)
+    error_message = "CPU must be one of 256, 512, 1024, 2048, 4096, or 8192."
+  }
+  validation {
+    // See https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#data
+    // for valid CPU and memory values.
+    condition = (
+      var.ecs-task_size.cpu == 256 ? contains([512, 1024, 2048], var.ecs-task_size.memory) :
+      var.ecs-task_size.cpu == 512 ? contains(range(1024, 4096, 1024), var.ecs-task_size.memory) :
+      var.ecs-task_size.cpu == 1024 ? contains(range(2048, 8192, 1024), var.ecs-task_size.memory) :
+      var.ecs-task_size.cpu == 2048 ? contains(range(4096, 16384, 1024), var.ecs-task_size.memory) :
+      var.ecs-task_size.cpu == 4096 ? contains(range(8192, 30720, 1024), var.ecs-task_size.memory) :
+      var.ecs-task_size.cpu == 8192 ? contains(range(16384, 61440, 4096), var.ecs-task_size.memory) :
+      true
+    )
+    error_message = "Invalid combination of CPU and memory."
+  }
+}
+
 variable ecs-task_cpu {
   type = number
   description = "CPU units for the ECS task"
@@ -95,6 +139,6 @@ variable ecs-task_cpu {
 variable ecs-task_memory {
   type = number
   description = "Memory units (MB) for the ECS task"
-  default = 5012
+  default = 5120
 }