Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for all functions #24

Closed
jacobbieker opened this issue Aug 26, 2022 · 1 comment
Closed

Add unit tests for all functions #24

jacobbieker opened this issue Aug 26, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jacobbieker
Copy link
Member

For PP production, all the functions are tested in the end2end test, but not all of them have individual unit tests, although most do. Would be good to have unit tests for all of them. Same for the non-production datapipes, unit tests are currently a bit spotty for them.

Detailed Description

Context

Possible Implementation

@jacobbieker jacobbieker added enhancement New feature or request good first issue Good for newcomers labels Aug 26, 2022
@peterdudfield
Copy link
Contributor

Think ill close this for the moment, there's fairly good coverage (80%). We can open sepecific tests like #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants