-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create API #133
Comments
Hey @peterdudfield , the run_forecast function uses make_pv_data in data.py, which in turn optionally uses the functions from enphase.py-where some functions require CLI inputs given by the user. Should it be like calling an API with a cURL-which only Linux users will be able to use ? Otherwise we'd have to make a .ps1 (powershell) file for windows-specific users to use the api. |
Perhaps we could focus on doing this without data from enphase first. I think a |
What is enphase.py |
I already created the API, though I'm curious should it exist within this repos folder or can be on its own folder and GitHub repo? |
enphase is a solar inverter, we trying to get this working so people can connect to their own solar panels and give a solar forecast |
I think what #146 has done with the API is the way forward. If #146 gets merged, can you build of that API? |
Hey @peterdudfield , which folder should the api file be in? any suggestions? or should i go ahead with making a new folder called "api"/"run_forecast_api.py" |
No need @aryanbhosale is already working on it. I think I'll just put my efforts on issue #93 |
I'm not working on it since #146 has already put in some work into it, you could try it out! |
Yeah, I will look into it, since she's already created the API all that's left is creating the schema and the Open API docs for interactivity. |
I think we should close this now, right? |
Yes I think this has been resolved |
Detailed Description
Create a simple API that could take in site level details and make a forecast
Context
from quartz_solar_forecast.forecast import run_forecast
Possible Implementation
run_forecast
The text was updated successfully, but these errors were encountered: