Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all tests work #187

Open
peterdudfield opened this issue Aug 30, 2024 · 4 comments
Open

Make sure all tests work #187

peterdudfield opened this issue Aug 30, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@peterdudfield
Copy link
Contributor

peterdudfield commented Aug 30, 2024

Detailed Description

Currently some of the tests fail when not running on the OCF github. This is due to some secrets not being shared.

Context

  • good to have all test passing, lets external contributors work on repo
  • Current tests that fail, not on OCF github
Screenshot 2024-08-30 at 08 14 26

Possible Implementation

The 4 tests that currenlty fail could be moved to integration tests. This could only run on main.
It would be good if we copy these tests and adjusted them into unit tests. I think the main thing is to mock the HF data that is downloaded.

@peterdudfield peterdudfield added the good first issue Good for newcomers label Aug 30, 2024
@peterdudfield peterdudfield mentioned this issue Aug 30, 2024
6 tasks
@peterdudfield
Copy link
Contributor Author

Current tests are failling, there were working here - , but not here. Is this due to a new package being released?

@peterdudfield
Copy link
Contributor Author

peterdudfield commented Sep 12, 2024

Cattrs 24.1.0, fast api 0.114.0, msgpack 1.0.8, multidict 6.05, nwharls 1.6.3, protobuf 5.28.0, pyasn1 0.6.0, pyasn modules, pytz 2024.01

Are the recent package changes

@sumana-2705
Copy link
Contributor

Hello @peterdudfield

Can I work on this issue?

@peterdudfield
Copy link
Contributor Author

Yes please. I think it's due to some tests needing HF credentials. We could perhaps create some public ones that might help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants