Potential bug in the sbuild runner

[mdimjasevic]

There is something that seems like a bug to me and it is in https://github.com/opencollab/debile/blob/master/debile/slave/runners/sbuild.py#L85 :

def ensure_chroot_sanity(chroot_name):
    out, _, _ = run_command(['schroot', '-l'])
    for chroot in out.splitlines():
        chroot = chroot.strip()
        chroots = [
            chroot,
            "chroot:%s" % (chroot)
        ]
        if chroot in chroots:
            return True
    raise ValueError("No such schroot (%s) found." % (chroot_name))

Shouldn't the if-statement read:

        if chroot_name in chroots:

instead?

[clemux]

I'd say it's very possible it's a bug :)

[mdimjasevic]

I can fix it and add a test case.

On May 29, 2016 11:46:31 PM MDT, "Clément Schreiner" [email protected] wrote:

I'd say it's very possible it's a bug :)

---

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#45 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

[clemux]

That'd be perfect!