Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submit expense page #10776

Merged
merged 28 commits into from
Dec 2, 2024
Merged

Add submit expense page #10776

merged 28 commits into from
Dec 2, 2024

Conversation

hdiniz
Copy link
Contributor

@hdiniz hdiniz commented Nov 4, 2024

@hdiniz hdiniz self-assigned this Nov 4, 2024
Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencollective-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 4:35pm
opencollective-styleguide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 4:35pm

@hdiniz hdiniz force-pushed the new-new-expense-flow branch from d18b2f7 to 1a7d7b7 Compare November 27, 2024 11:47
Copy link
Member

@gustavlrsn gustavlrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having some issues when trying to submit, the expense items section fails the validation and is marked as required, but unclear what is missing:

image

@gustavlrsn
Copy link
Member

gustavlrsn commented Nov 29, 2024

Might only be my development environment, but getting this "problem refreshing the Wise token" when trying to submit:

image

@gustavlrsn
Copy link
Member

Validation hint missing when not having selected the type of expense:

image

@hdiniz
Copy link
Contributor Author

hdiniz commented Nov 29, 2024

I have made the default expense type selection to invoice and fixed the validation hint on the expense item attachment.

For testing locally, try submitting with a payment method of type Other as that does not require any integrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants