Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify OS.INSTALL RPC behavior when gRPC session disconnects abruptly during an active image transfer before TransferEnd is received #179

Open
pranav-jnpr opened this issue Mar 15, 2024 · 1 comment

Comments

@pranav-jnpr
Copy link

pranav-jnpr commented Mar 15, 2024

If the gRPC session terminates for some reason while the image transfer is in progress, and the server never receives the "TransferEnd" request, should the server clean up by deleting the file which had been transferred upto that point and stop expecting the next set of bytes? This seems logical, as the alternative - setting up a new session, will require a method to synchronize state.

Another scenario to consider is when transfer is completed and client has sent transfer end, but device has not yet sent "Validated" message, but the gRPC session has gone down.

Perhaps add a clarification to the proto through a comment as well to standardize the behavior?

@marcushines
Copy link
Contributor

The expectation is that any transfer which doesn't complete successfully will be cleaned up. Currently there is no defined "resume" functionality in the spec so there shouldn't be any expectation on server side for a client to be able to resume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants