From 60e638677a5532a2789c69a4a62bde05b247c8e9 Mon Sep 17 00:00:00 2001 From: Neha Manjunath Date: Tue, 25 Jul 2023 13:21:19 +0000 Subject: [PATCH] Incorporate review comments --- events/events.go | 6 +++--- events/status.go | 9 ++++----- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/events/events.go b/events/events.go index ad68849e..15ee0cec 100644 --- a/events/events.go +++ b/events/events.go @@ -1,4 +1,4 @@ -// Package events provides events status for a namespace using kubectl. +// Package events provides events status for a namespace. package events import ( @@ -108,7 +108,7 @@ func EventToStatus(event *corev1.Event) *EventStatus { } event.DeepCopyInto(&s.Event) event = &s.Event - s.Type = event.DeepCopy().Type - s.Message = event.DeepCopy().Message + s.Type = event.Type + s.Message = event.Message return &s } diff --git a/events/status.go b/events/status.go index 0632d759..2df34829 100644 --- a/events/status.go +++ b/events/status.go @@ -25,9 +25,8 @@ type Watcher struct { stdout io.Writer warningf func(string, ...any) - mu sync.Mutex - progress bool - currentNamespace string + mu sync.Mutex + progress bool } var errorMsgs = [2]string{"Insufficient memory", "Insufficient cpu"} @@ -89,9 +88,9 @@ func (w *Watcher) Cleanup(err error) error { select { case werr := <-w.errCh: if err != nil { - w.warningf("Create() failed: %v", err) + w.warningf("Event Watcher failed: %v", err) } - w.warningf("Topology creation failed: %v", werr) + w.warningf("Event Watcher error: %v", werr) return werr default: }