Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route-policy:defined-sets:bgp-defined-sets:ext-community-sets members type #901

Closed
rcicu opened this issue Jul 5, 2023 · 3 comments · May be fixed by #883
Closed

route-policy:defined-sets:bgp-defined-sets:ext-community-sets members type #901

rcicu opened this issue Jul 5, 2023 · 3 comments · May be fixed by #883
Assignees
Labels

Comments

@rcicu
Copy link

rcicu commented Jul 5, 2023

leaf-list ext-community-member {

Currently ext-community-member is a list of oc-bgp-types:bgp-ext-community-type and oc-bgp-types:bgp-community-regexp-type but it will not be beneficial to have it as a list of containers?

Having to delete one entry for the list is difficult, since you need to know that values are there and update the list with all the values, except the target one. Using a list of containers it will allow to apply a YFilter.delete to the desired entry. This is similar to how prefixes are removed from route-policy:defined-sets:prefix-sets.

Or there is another way to do that without knowing the values before?

@dplore dplore self-assigned this Jul 25, 2023
@dplore
Copy link
Member

dplore commented Jul 25, 2023

I am working to refactor the bgp communities from a union type of many regex strings to explicitly defined types in containers.

I think the community-set will still be a list, but pointing to a list of containers instead of a list of strings.

Copy link

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 10, 2024
@dplore
Copy link
Member

dplore commented May 10, 2024

@rcicu the refactored bgp community model with communities modeled with strongly typed leafs in containers is here: #883

I'd apprecaite a review if you are interested.

@dplore dplore linked a pull request May 10, 2024 that will close this issue
@rcicu rcicu closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants