Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Error in GNMI SetRequest Error Handling Description #212

Open
idokor opened this issue Jul 11, 2024 · 0 comments
Open

Documentation Error in GNMI SetRequest Error Handling Description #212

idokor opened this issue Jul 11, 2024 · 0 comments

Comments

@idokor
Copy link

idokor commented Jul 11, 2024

There is a discrepancy in the GNMI documentation regarding the error handling of SetRequest messages as described in Section 3.4.3. The documentation states that in the case of any operation within the SetRequest message failing, the status code of the SetResponse should be set to Aborted (10) with an appropriate error message. Additionally, it requires setting the message field of the UpdateResult corresponding to the failed operation to an error message, and for other operations, setting the code field to Aborted (10).

In practice, for Go/Python clients using the proto, setting the status code to anything other than OK implies that the SetResponse is not received by the client. This contradicts the suggestion of sending a SetResponse message with status code Aborted (10) and corresponding error details, as the client won't be able to retrieve or view these messages.

Additionally, the requirement specifies modifying the deprecated error message field inside the SetResponse proto, which may not be effective or recommended in modern implementations.

  1. Am I missing something, or did I misunderstand the specification concerning how clients are expected to handle SetResponse messages with non-OK status codes?
  2. Is there a specific way that the SetResponse should be sent to ensure clients can receive and process the error details effectively, despite the non-OK status code?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant