feat: support for diffing presence containers #990
+174
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
JonasKs
force-pushed
the
support-presence-containers
branch
from
4970f67
to
519ff68
Compare
|
Hello @wenovus and @robshakir - it took some time, but we finally managed to crack the code. Please review. 😊 |
JonasKs
force-pushed
the
support-presence-containers
branch
from
519ff68
to
58943fa
Compare
Co-authored-by: Terje Lafton <[email protected]>
JonasKs
force-pushed
the
support-presence-containers
branch
from
58943fa
to
8c252eb
Compare
Co-authored-by: Terje Lafton <[email protected]>
|
Also tagging #645 author, @hansthienpondt. |
Co-authored-by: Terje Lafton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #936.
The implementation ended up being somewhat as described in #936, where we indicate that presence container has a
nilvalue in thefindSetLeavesfunction.In addition to this, we added a presence container interface, which is used in the
marshalStructOrOrderedListto isolate the presence container which might have values, to act like an empty struct.The result is that we do not break any current tests (even without the diff option), but we decided to add a diff option, with the reasoning described in #936:
We've confirmed this works in our setup. We're able to successfully configure all presence containers, even nested ones.
Co-authored-by: Terje Lafton [email protected]