Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify incompatible ingredient/dietary-property combinations #108

Open
jayaddison opened this issue Aug 21, 2022 · 0 comments
Open

Identify incompatible ingredient/dietary-property combinations #108

jayaddison opened this issue Aug 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jayaddison
Copy link
Member

jayaddison commented Aug 21, 2022

Is your feature request related to a problem? Please describe.
As part of openculinary/frontend#211 we are adding the ability for users to filter recipe results based on dietary requirements (vegan, dairy-free, ...).

This opens the possibility that users may add ingredients to their search criteria that will never match based on the selected dietary properties.

For example, a search for vegan and chicken -- in the (current) absence of support for substitutions of ingredients (like plant-based chicken alternatives) -- will never match any results.

Describe the solution you'd like
When a search is performed, we should check for any dietary filters applied, and cross-reference these against the list of ingredients selected in the include (positive-match) query ingredients.

For any cases where an include ingredient will never match based on the dietary properties, we should add a refinement note (a hint displayed above the search results in the user interface) to indicate that the user may want to check whether they intended to search for the relevant ingredient(s).

We may also want to add a strikethrough to each affected ingredient in the search controls to indicate their omission from the query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant