-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodata for product definition doesnt match dtype #1348
Comments
Our validator is correctly failing the product --- should this issue go to ODC core? |
@SpacemanPaul suggested this is not core's issue, it was just transferred here from core |
I'm not that strongly opinionated on the matter. What would the metadata fix be though? What does a nodata value on a floating point variable even mean? |
nodata supported type can be anything as per odc schema https://github.com/opendatacube/datacube-core/blob/develop/datacube/model/schema/dataset-type-schema.yaml#L97-L100
dtype restriction https://github.com/opendatacube/datacube-core/blob/develop/datacube/model/schema/dataset-type-schema.yaml#L54-L55 |
same as for an |
The real value is probably:
test in numpy_value_fits_dtype return np.all(np.array([value], dtype=dtype) == [value]) doesn't check what it claims, it checks that value can round-trip to numpy and back, and that's only appropriate for integer types. Value as supplied, is probably incorrect because of precision loss, but it is surely not outside of valid range for float32 number. |
checking the dataset in middle of the ocean
the output of stored
|
|
Example of datacube's
|
@robbibt can you try patching |
What about |
@Kirill888 That works!
Not sure what you mean by this, do you mean the nodata attributes on the different bands of the dataset? |
Is there |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
related to: GeoscienceAustralia/dea-config#1110
eo3-validate
type handling needs updateThe text was updated successfully, but these errors were encountered: