diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 5b82a9cc..2ee1b0d1 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -38,7 +38,6 @@ jobs: - name: Install dependencies and run pylint run: | pip install .[test,dev] - pip install pylint pylint -j 2 --reports no datacube_ows --disable=C,R,W,E1136 flake8: diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 29e01851..07a8b849 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -19,7 +19,7 @@ repos: # hooks: # - id: bandit - repo: https://github.com/PyCQA/pylint - rev: v3.1.0 + rev: v3.2.3 hooks: - id: pylint args: ["--disable=C,R,W,E1136"] diff --git a/datacube_ows/data.py b/datacube_ows/data.py index 33a9b5da..802a9501 100644 --- a/datacube_ows/data.py +++ b/datacube_ows/data.py @@ -671,6 +671,8 @@ def get_s3_browser_uris(datasets, pt=None, s3url="", s3bucket=""): if ds.crs != last_crs: pt_native = pt.to_crs(ds.crs) last_crs = ds.crs + else: + pt_native = pt if ds.extent.contains(pt_native): uris.append(ds.uris) else: diff --git a/datacube_ows/ogc_utils.py b/datacube_ows/ogc_utils.py index 3d6458d2..0a620ef4 100644 --- a/datacube_ows/ogc_utils.py +++ b/datacube_ows/ogc_utils.py @@ -526,7 +526,7 @@ def create_geobox( if width is not None: scale_x = (float(maxx) - float(minx)) / width else: - scale_x = -scale_y + scale_x = -scale_y # pylint: disable=possibly-used-before-assignment width = int(round((float(maxx) - float(minx)) / scale_x)) if height is None: scale_y = - scale_x diff --git a/setup.py b/setup.py index 8142763a..4233d37d 100644 --- a/setup.py +++ b/setup.py @@ -50,7 +50,7 @@ dev_requirements = [ 'pydevd-pycharm~=221.5921.27', # For Pycharm 2022.1.3 - 'pylint==2.4.4', + 'pylint==3.2.3', 'sphinx_click', 'pre-commit==2.13.0', 'pipdeptree'