Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency issues with Dask and Python 3.8 #174

Open
robbibt opened this issue Sep 8, 2024 · 1 comment
Open

Dependency issues with Dask and Python 3.8 #174

robbibt opened this issue Sep 8, 2024 · 1 comment

Comments

@robbibt
Copy link
Contributor

robbibt commented Sep 8, 2024

Hi all, setup.cfg specifies that odc-stac supports Python 3.8:
https://github.com/opendatacube/odc-stac/blob/develop/setup.cfg#L33

However, I'm having dependency issues with Dask when trying to build an environment that works with 3.8. The latest version of Dask that supports Python 3.8 is dask==v2023-5-0:
https://docs.dask.org/en/stable/changelog.html#v2023-5-1

However, if I try and use dask==2023.5.0 with odc-stac, I get the following error:

import odc.stac

Traceback:
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_foo.py:5: in <module>
    import odc.stac
.venv/lib/python3.8/site-packages/odc/stac/__init__.py:4: in <module>
    from odc.loader._rio import configure_rio, configure_s3_access
.venv/lib/python3.8/site-packages/odc/loader/__init__.py:5: in <module>
    from ._builder import chunked_load, resolve_chunk_shape
.venv/lib/python3.8/site-packages/odc/loader/_builder.py:[32](https://github.com/robbibt/eo-tides/actions/runs/10757894621/job/29832491543#step:5:33): in <module>
    from dask.typing import Key
E   ImportError: cannot import name 'Key' from 'dask.typing' (/home/runner/work/eo-tides/eo-tides/.venv/lib/python3.8/site-packages/dask/typing.py)

Which I think is because Key was only added in this commit:
dask/dask@b015ea8#diff-4ca1f6adfeb89f24ac8297d11e1b911ffa6243bbf12f1b17fa556bae1f93c7a2R19

Does the minimum Python version for odc-stac need to be increased to 3.9? Or is there a workaround so that we can use an older version of Dask for Python 3.8?

@Kirill888
Copy link
Member

#164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants