Duplication in functionality between erase_bad and keep_good_only

[robbibt]

The following two odc.algo functions appear to do the same thing: replace certain pixels in an array with nodata. To reduce confusion, it would be good to have only one clear option for this kind of task.

odc.algo.erase_bad(...)
odc.algo.keep_good_only(...)

The docstrings seem to say the same thing:

Return a copy of x, but with some pixels replaced with nodata.
This function can work on dask arrays, in which case output will be a dask array as well.

[Kirill888]

code is the same too, my guess it was attempt at rename that didn't merge correctly.

@robbibt which name do you think works better?

[robbibt]

I like erase_bad, simpler and more direct

[Kirill888]

@robbibt Actually they are different, and documentation does differ between the two ever so slightly

erase_bad removes those pixels that are marked True in the mask, while keep_good_only erases pixels that are marked False in the mask.