Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the failing TestRayJobSubmissionRest test #110

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix the failing TestRayJobSubmissionRest test #110

merged 1 commit into from
Sep 6, 2023

Conversation

jiripetrlik
Copy link
Contributor

@jiripetrlik jiripetrlik commented Sep 5, 2023 •
edited
Loading

Description

Timeout which waits for 200 reply from dashboard route was added.

Fixes: red-hat-data-services#5

Merge criteria:

  • [*] The commits are squashed in a cohesive manner and have meaningful messages.
  • [*] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [*] The developer has manually tested the changes and verified that the changes work

@jiripetrlik jiripetrlik requested review from sutaakar and winklerm and removed request for KPostOffice and dimakis September 5, 2023 15:27
@winklerm
Copy link

winklerm commented Sep 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2023
sutaakar
sutaakar approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for immediate issue.
Though I was thinking about more generic solution - something like exposeService accepting namespace and service name, creating Route, waiting for it to be ready.

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit f1ca5c8 into opendatahub-io:main Sep 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar sutaakar approved these changes

@winklerm winklerm Awaiting requested review from winklerm

Assignees

@winklerm winklerm

@sutaakar sutaakar

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the failing KubeRay tests running with downstream RHODS operator
4 participants
@jiripetrlik @winklerm @sutaakar @openshift-merge-robot