Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to the granite provided by rhel ai rather than huggingface #152

Open
cooktheryan opened this issue Nov 4, 2024 · 5 comments
Open
Assignees
Labels

Comments

@cooktheryan
Copy link
Collaborator

cooktheryan commented Nov 4, 2024

ilab model download --repository docker://registry.redhat.io/rhelai1/granite-7b-starter --release latest

Transition the above command into the pipeline rather than using huggingface

@tumido tumido self-assigned this Nov 11, 2024
@tumido
Copy link
Member

tumido commented Nov 13, 2024

Sadly ilab model download makes things only complicated:

IMO it would be much better if we could use https://github.com/containers/ramalama or oras or something else instead of relying on this head-scratch logic by ilab...

The most demanding part would be to re-create/undo the symlinking, since we can't rely on that in KFP.

@tumido
Copy link
Member

tumido commented Nov 13, 2024

Additionally, ilab model download also allows to download models from HuggingFace, however their solution requires HuggingFace token to be always present, compared to our solution which doesn't require that. This would result in regression or added logic/requirement to provide a HuggingFace token...

https://github.com/instructlab/instructlab/blob/fa6073daf084f24346af05c021feb8f1eaa4cc44/src/instructlab/model/download.py#L73-L78

@leseb
Copy link
Collaborator

leseb commented Nov 14, 2024

@tumido, for a small clarification, the token is not needed if we download an image from the instructlab repository. By the way, I'm curious how other projects handle the token.

@tumido
Copy link
Member

tumido commented Nov 14, 2024

Yeah, correct. However so far we've been using ibm-granite/granite-7b-base as the default base model. This model can be downloaded without auth, but not via ilab model download (as a workaround, setting HF_TOKEN to invalid, stub value, works just fine here).

@tumido
Copy link
Member

tumido commented Nov 15, 2024

FTR, we took this back to stakeholders, since we're not sure at the moment how aligned is OCI Artifacts or even Hugging face as model sources relevant to Phase 3 as it should stay close to Phase 2 experience. Our offer is to revert to sourcing the model from object storage in the phase 3 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants