Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Check Dockerfile labels for images #292

Open
jstourac opened this issue Oct 27, 2023 · 0 comments
Open

[Test] Check Dockerfile labels for images #292

jstourac opened this issue Oct 27, 2023 · 0 comments
Assignees
Labels
JIRA jira issue exists for following github issue kind/feature New feature or request priority/normal An issue with the product; fix when possible

Comments

@jstourac
Copy link
Member

jstourac commented Oct 27, 2023

Let's review and check the content of the labels in Dockerfiles for runtimes (maybe also others?) images here in this repository !and also in downstream repo! . Namely these labels should be checked for content on our branches:

  • authoritative-source-url
  • io.openshift.build.commit.ref
  • io.openshift.build.source-location
  • io.openshift.build.image

https://issues.redhat.com/browse/RHOAIENG-229

@github-project-automation github-project-automation bot moved this to 📋 Backlog in ODH IDE Planning Oct 27, 2023
@harshad16 harshad16 added kind/feature New feature or request priority/normal An issue with the product; fix when possible labels Oct 27, 2023
@jstourac jstourac changed the title Check Dockerfile labels for images [Test] Check Dockerfile labels for images Oct 31, 2023
@jstourac jstourac self-assigned this Nov 3, 2023
jstourac added a commit to jstourac/notebooks that referenced this issue Nov 3, 2023
This change tries to deduplicate some strings in our docker image labels
with ability to propagate some common values directly from the Makefile
so we don't need to change these values with every release branch or for
every newly introduced docker image.

There were some minor fixes in the labels introduced too in this commit.

---

Relates to: opendatahub-io#292
jstourac added a commit to jstourac/notebooks that referenced this issue Nov 3, 2023
This change tries to deduplicate some strings in our docker image labels
with ability to propagate some common values directly from the Makefile
so we don't need to change these values with every release branch or for
every newly introduced docker image.

There were some minor fixes in the labels introduced too in this commit.

---

Relates to: opendatahub-io#292
@harshad16 harshad16 moved this from 📋 Backlog to 🏗 In Progress in ODH IDE Planning Nov 6, 2023
jstourac added a commit to jstourac/notebooks that referenced this issue Nov 6, 2023
This change tries to deduplicate some strings in our docker image labels
with ability to propagate some common values directly from the Makefile
so we don't need to change these values with every release branch or for
every newly introduced docker image.

There were some minor fixes in the labels introduced too in this commit.

---

Relates to: opendatahub-io#292
@harshad16 harshad16 moved this from 🏗 In Progress to 👀 In Review in ODH IDE Planning Nov 21, 2023
@harshad16 harshad16 moved this from 👀 In Review to 🏗 In Progress in ODH IDE Planning Nov 21, 2023
@adrielparedes adrielparedes added the JIRA jira issue exists for following github issue label Dec 1, 2023
jstourac added a commit to jstourac/notebooks that referenced this issue Dec 7, 2023
This change tries to deduplicate some strings in our docker image labels
with ability to propagate some common values directly from the Makefile
so we don't need to change these values with every release branch or for
every newly introduced docker image.

There were some minor fixes in the labels introduced too in this commit.

---

Relates to: opendatahub-io#292
jstourac added a commit to jstourac/notebooks that referenced this issue Feb 2, 2024
This change tries to deduplicate some strings in our docker image labels
with ability to propagate some common values directly from the Makefile
so we don't need to change these values with every release branch or for
every newly introduced docker image.

There were some minor fixes in the labels introduced too in this commit.

---

Relates to: opendatahub-io#292
jstourac added a commit to jstourac/notebooks that referenced this issue Feb 13, 2024
This change tries to deduplicate some strings in our docker image labels
with ability to propagate some common values directly from the Makefile
so we don't need to change these values with every release branch or for
every newly introduced docker image.

There were some minor fixes in the labels introduced too in this commit.

---

Relates to: opendatahub-io#292
jstourac pushed a commit to jstourac/notebooks that referenced this issue Jul 18, 2024
…st-updater-9712923870

[Digest Updater Action] Update Runtime Images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JIRA jira issue exists for following github issue kind/feature New feature or request priority/normal An issue with the product; fix when possible
Projects
Status: No status
Status: No status
Status: 🏗 In Progress
Development

No branches or pull requests

3 participants