-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODS box build has been failing since 2020-09-01 12:00 #795
ODS box build has been failing since 2020-09-01 12:00 #795
Comments
@georgfedermann Any chance to get those logs out of the machine? If not, that is something we should add to our list. Should be easy to know what the issue is when one sees the Jenkins log. As there is no change I'm aware of, I guess some kind of JS dependency issue. @herrkoch @cschweikert would one of you be able to look into this - by running the cypress test in our cluster? |
@michaelsauter I'll run a manual build and will post the logs here as soon as available. |
Maybe it's a "latest" version of cypress topic? .. just thinking out loud .. or some weird version incompatibility. |
@michaelsauter - we should be able to dump the jenkins run log (the script is there) in case of a test error? |
@clemensutschig Yes, that's what I meant with "If not, that is something we should add to our list." .. just terribly worded :) I added a feature request at #796. |
Hi, I can add to this that I recently updated dependencies in the Cypress quickstarter. The Jenkins build of my provisioned Cypress quickstarter ran fine in my OpenShift playground. I haven't seen the tests described here though, not sure how to execute these and where they can be found. |
@herrkoch See https://github.com/opendevstack/ods-core/tree/master/tests#ods-core---tests. Your reps changes sound unrelated because it has worked between then and this Tuesday. |
@michaelsauter here is the Jenkins log output for the failing cypress build unitt-cd/run-unitt-cypress-unitt-master
|
Hmm really strange, it is throwing linting errors for a file inside |
interesting indeed ... is there some flag to exclude this? |
I guess the reason is this line: https://github.com/opendevstack/ods-quickstarters/blob/a21cf1938e7ab549377458dc816737e96a8f9ca0/e2e-cypress/files/tsconfig.json#L6 |
@cschweikert - what's weird is that we lock the version ... was there an update yesterday against cypress types? |
Could have been introduced by this change 14 days ago: opendevstack/ods-quickstarters@823f86f |
@cschweikert - this worked until yesterday? .. is there something screwed up in the pkg json? |
Good catch @cschweikert. I was able to reproduce the issue and found the cause: In the quickstarter we have no |
I will provide a PR. Should I additionally fix the dependencies in the package.json to a specific minor version or continue to have the |
It could be, that this line is needed for having proper typing support. Maybe it make sense to test with an IDE like vscode, if code completion is still working for |
I guess it is also fine to point to |
Thanks for the hint @cschweikert, I checked with my IntelliJ IDEA, at least there auto-completion still worked after removing the include. I just asked live in the frontend community call what they prefer for the quickstarter to have, fixed dependencies with |
Describe the bug
During ODS box AMI build the cypress tests are failing with the logs quoted below.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The tests should pass
Affected version (please complete the following information):
Log Output (ensure to remove any confidential information like tokens, project names, etc.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: