Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explanation of parameter shapes #11

Open
LongLiveForFreedom opened this issue Jul 18, 2024 · 3 comments
Open

explanation of parameter shapes #11

LongLiveForFreedom opened this issue Jul 18, 2024 · 3 comments

Comments

@LongLiveForFreedom
Copy link

Hello, thanks you for your great work! There's something about your code that bothers me.
For example, in eval_store.py, you mentioned that the shape of pred_trajectory is [K, N, T(future), 2] and the shape of embeds is [K, N, -1](in my code is [K, N, H, D]). But in line 124 of target_region.py, the shape of y_hat_init should be [N, K, F, 2] and y_hat_delta [K*N, F, 2], why can they be added together(the option y_hat_init = y_hat_init + y_hat_delta)

@LongLiveForFreedom
Copy link
Author

In line 217 of target_region.py(refine_y_hat_delta = self.refine_decoder[0](ego_embed + self.pos_embed[refine_iter+1])), the shape of ego_embed should be [K, N, H*D(hidden dimension)] and the shape of pos_embed[refine_iter+1] should be [1, D], they also be added together

@youngzhou1999
Copy link
Collaborator

Thanks for trying our code and sorry for the inconvenience.
In a normal situation, the shape of ego embeds should be [K, N, D] and H(history) irrelevant since one embedding is for one trajectory.
For the code shape problem, I'll rerun the eval process and check the code.

@LongLiveForFreedom
Copy link
Author

thank you for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants