Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Two toast notifications when delete one running detector on detector list #236

Open
ylwu-amzn opened this issue Jun 23, 2020 · 5 comments
Open
Assignees
Labels
enhancement Enhance current feature for better performance, user experience, etc

Comments

@ylwu-amzn
Copy link
Contributor

Will show two toast notifications when delete on running detector with batch action on detector list.

Screen Shot 2020-06-23 at 10 31 02 AM

@ylwu-amzn ylwu-amzn changed the title Multiple toast notification when delete one running detector on detector list Two toast notifications when delete one running detector on detector list Jun 23, 2020
@ylwu-amzn ylwu-amzn added the bug Something isn't working label Jun 23, 2020
@ohltyler
Copy link
Contributor

So when we delete a single running detector via detector details page, it does the same thing, so I was trying to replicate the functionality here. Maybe we decide to either remove this double notification from both the detector detail delete and batch action delete, or change the button to say something like 'Stop and delete' if the detectors to delete are running. Thoughts?

@ylwu-amzn ylwu-amzn added enhancement Enhance current feature for better performance, user experience, etc and removed bug Something isn't working labels Jun 23, 2020
@ylwu-amzn
Copy link
Contributor Author

Sorry, I should set enhancement tag for this issue. Can we merge these two notifications into one? I feel it's annoying to read two notifications. We can confirm with UX designer to get more feedback.

@ohltyler
Copy link
Contributor

ohltyler commented Jun 23, 2020

Sure, I'll reach out to UX about this. My one reason for maybe wanting to leave it is that it could provide the user with more information if the stop-and-delete action fails halfway through, but it also shouldn't be the user's responsibility to understand the internal functionality when a running detector gets deleted.

@ohltyler
Copy link
Contributor

@ylwu-amzn confirmed with UX to remove the stopped toast. Will have to be changed in the batch actions as well as the delete workflow from detector details page.

@ohltyler ohltyler assigned ohltyler and unassigned ohltyler Jun 23, 2020
@ylwu-amzn
Copy link
Contributor Author

@ylwu-amzn confirmed with UX to remove the stopped toast. Will have to be changed in the batch actions as well as the delete workflow from detector details page.

Cool, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhance current feature for better performance, user experience, etc
Projects
None yet
Development

No branches or pull requests

2 participants