From e931768c3908c07b29a969c70ef1b899c2b7d8cd Mon Sep 17 00:00:00 2001 From: Tim McCormack Date: Tue, 1 Aug 2023 14:14:13 -0400 Subject: [PATCH] fix: Use correct name for --detach param (#1140) `-d` is valid and so is `--detach`. But the `--d` that was used here (with two hyphens) only worked on some machines. I believe that was autocorrected to `--detach` on those machines because it was a unique prefix, as I was also able to use `--det`. This might be a matter of versions, or of `docker-compose` vs. `docker compose` shims, or just difference by OS. But in any case we should use a documented version of the flag. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 76838be47d..6ab4160511 100644 --- a/Makefile +++ b/Makefile @@ -302,7 +302,7 @@ dev.up.with-watchers.%: ## Bring up services and their dependencies + asset watc dev.up.without-deps: _expects-service-list.dev.up.without-deps impl-dev.up.without-deps.%: dev.check-memory ## Bring up services by themselves. - docker-compose up --d --no-deps $$(echo $* | tr + " ") + docker-compose up -d --no-deps $$(echo $* | tr + " ") dev.up.without-deps.%: ## Bring up services by themselves. @scripts/send_metrics.py wrap "dev.up.without-deps.$*"