-
Notifications
You must be signed in to change notification settings - Fork 423
fix: increase compose command timeout so that devstack make commands don't fail #1066
Conversation
Thanks for the pull request, @XLAR-8! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @XLAR-8, thank you for this contribution! As the bot mentioned, the next step will be for you to sign the Open edX Contributor Agreement. Then we can enable tests for this PR, and get it into the review queue. |
@itsjeyd can you please check again, I have signed contribution form ? |
Thanks for the update @XLAR-8. Could you please update the title of the PR to trigger a re-run of the CLA check?
|
@itsjeyd done |
Thank you @XLAR-8! The CLA check passed, so we're ready to move forward with next steps. Could you please update your branch so that it includes the latest changes from master? Once that's done we'll enable CI checks for your changes. |
Updating via a merge commit which will re-run the tests. |
Please amend your commit messages to follow the conventional commit format described here. |
@XLAR-8 A friendly reminder to update your commit messages. This will fix the build :) Once everything is green we'll line up your changes for engineering review. |
@XLAR-8 Thanks for the update. It looks like one of your commit messages will need further adjustment. From the commitlint output:
What that tells me is that if you change
to
... the build should turn green. |
@itsjeyd this is done |
Hey @XLAR-8, it looks like you updated the title of the PR, but not the commit message? I'm still seeing This page explains how to change commit messages and overwrite commits that have already been pushed to GitHub. |
…supported#1018) * feat: target dev image changed for LMS and Studio * fix: env variables updated for lms and cms * fix: rollback pip.txt changes * fix: lms_watcher target updated
…openedx-unsupported#1038) Recently, as part of PR openedx-unsupported#1021, we had renamed the `dev.down` command to `dev.remove-containers` in order to try and make it a bit clearer what the command is doing behind the scenes. We still have a few commands that are trying to use the `dev.down` variant of the command. This PR updates a few remaining uses of `dev.down` to use the new syntax.
…nedx-unsupported#1080) The only thing that most developers use from the devstack requirements file is docker-compose, and that's already provided by a Docker installation on some operating systems. So just change the Docker installation instructions to mention docker-compose, and then drop virtualenvs from the getting started and main workflow docs. This commit does not change `docs/developing_on_named_release_branches.rst` as that file is for an uncommon use-case. Removing virtualenv instructions from that file would require getting multi-devstack set up in the first place and then removing all the virtualenv referenves from the scripts that are laid out in the doc. If it's worth doing that, it's best done by someone who already uses those instructions. Issue: openedx-unsupported#1076
This workflow adds a follow-up checklist for arch-bom developers to use when triaging bugs. edx/edx-arch-experiments#310
…penedx-unsupported#1099) The e2e tests repo is deprecated and is no longer part of Open edX.
Co-authored-by: Usama Sadiq <[email protected]>
…ported#1104) Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 5f728c3dae25f329afbe34ee4d08eef25569d79f to 411d7f9b4092af4736447c5420752e3b2be55ec1. - [Release notes](https://github.com/peter-evans/create-or-update-comment/releases) - [Commits](peter-evans/create-or-update-comment@5f728c3...411d7f9) --- updated-dependencies: - dependency-name: peter-evans/create-or-update-comment dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tack into fix-make-cmd-timeout
The branch now seems to contain about 55 more commits than expected, at least according to GitHub. Maybe a rebase error? |
Hi @XLAR-8, just checking in to see if you're still planning to work on this PR? |
Hi @XLAR-8! Just a quick update that I'm closing this PR now because it is stale. You may reopen this pull request, or open a new one, when you have time to come back to this work. Thanks! |
@XLAR-8 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@XLAR-8 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Solves issue: devstack/issues/1031
Description:
Increaing Docker Compose HTTP timeout, in seconds, so that devstack make commands do not fail.
I've completed each of the following or determined they are not applicable: