Merge pull request #494 from edx/ajpal/date-link

Remove Date Last Updated from roster view
openedx-unsupported · Jun 29, 2016 · 0acb206 · 0acb206
2 parents 01103b3 + f6e60c7
commit 0acb206
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 12 deletions.
diff --git a/analytics_dashboard/static/apps/learners/app/spec/controller-spec.js b/analytics_dashboard/static/apps/learners/app/spec/controller-spec.js
@@ -28,7 +28,7 @@ define(function (require) {
             expect(controller.options.rootView.$('.learners-header-region').html())
                 .toContainText('Learner Details');
             expect(controller.options.rootView.$('.learners-header-region').html())
-                .toContainText(date.toLocaleDateString('en-us', {year: 'numeric', month: 'long', day: 'numeric'}));
+                .not.toContainText(date.toLocaleDateString('en-us', {year: 'numeric', month: 'long', day: 'numeric'}));
             expect(controller.options.trackingModel.get('page')).toBe('learner_details');
             expect(controller.options.trackingModel.trigger).toHaveBeenCalledWith('segment:page');
         };

diff --git a/analytics_dashboard/static/apps/learners/app/templates/header.underscore b/analytics_dashboard/static/apps/learners/app/templates/header.underscore
@@ -1,4 +1,3 @@
 <div class="section-heading bordered">
     <h4 class="section-title"><%- title %></h4>
-    <span class="section-heading-note small"><%- lastUpdated %></span>
 </div>
diff --git a/analytics_dashboard/static/apps/learners/app/views/header.js b/analytics_dashboard/static/apps/learners/app/views/header.js
@@ -7,7 +7,6 @@ define(function (require) {
     var _ = require('underscore'),
         Marionette = require('marionette'),
 
-        Utils = require('utils/utils'),
         headerTemplate = require('text!learners/app/templates/header.underscore'),
 
         HeaderView;
@@ -21,13 +20,8 @@ define(function (require) {
         },
 
         templateHelpers: function () {
-            var lastUpdatedMessage = _.template(gettext('Date Last Updated: <%- lastUpdatedDateString %>')),
-                lastUpdatedDateString = this.model.has('lastUpdated') ?
-                    Utils.formatDate(this.model.get('lastUpdated')) :
-                    gettext('unknown');
             return {
-                title: this.model.get('title'),
-                lastUpdated: lastUpdatedMessage({lastUpdatedDateString: lastUpdatedDateString})
+                title: this.model.get('title')
             };
         }
 

diff --git a/analytics_dashboard/static/apps/learners/app/views/spec/header-spec.js b/analytics_dashboard/static/apps/learners/app/views/spec/header-spec.js
@@ -21,7 +21,7 @@ define(function (require) {
             }).render();
 
             expect(fixture).toContainText('First Title');
-            expect(fixture).toContainText('Date Last Updated: unknown');
+            expect(fixture).not.toContainText('Date Last Updated: unknown');
             pageModel.set('title', 'Updated Title');
             expect(fixture).toContainText('Updated Title');
         });
@@ -37,7 +37,7 @@ define(function (require) {
                 model: pageModel
             }).render();
 
-            expect(fixture).toContainText('Date Last Updated: January 15, 2016');
+            expect(fixture).not.toContainText('Date Last Updated: January 15, 2016');
         });
 
     });

diff --git a/analytics_dashboard/static/apps/learners/app/views/spec/root-spec.js b/analytics_dashboard/static/apps/learners/app/views/spec/root-spec.js
@@ -29,7 +29,7 @@ define(function (require) {
 
         it('renders a header title and date', function () {
             expect(this.rootView.$('.learners-header-region').html()).toContainText('Testing Title');
-            expect(this.rootView.$('.learners-header-region').html()).toContainText('February 28, 2016');
+            expect(this.rootView.$('.learners-header-region').html()).not.toContainText('February 28, 2016');
         });
 
         it('renders and clears alerts', function () {