build: add support for node 16

.github/scripts/testing.sh

@@ -1,8 +1,20 @@
+if [[ $NODE == 16 ]]
+then
+  export NODE_VERSION=16.14.0
+else
+  export NODE_VERSION=12.11.1
+fi
+
 docker exec -t insights_testing bash -c "
     cd /edx/app/insights/edx_analytics_dashboard/ &&
     source /edx/app/insights/venvs/insights/bin/activate &&
     PATH=\$PATH:/edx/app/insights/nodeenvs/insights/bin:/snap/bin &&
     export TOXENV=django32 &&
     pip install -r requirements/github.txt &&
+    set -x &&
+    rm -rf /edx/app/insights/nodeenvs/insights-test-${NODE} &&
+    nodeenv --node=${NODE_VERSION} /edx/app/insights/nodeenvs/insights-test-${NODE} &&
+    source /edx/app/insights/nodeenvs/insights-test-${NODE}/bin/activate &&
+    node --version && npm --version
     make $TARGETS
-"
+"

.github/workflows/ci.yml

@@ -11,6 +11,7 @@ jobs:
     strategy:
       matrix:
         python-version: ["3.8"]
+        node: [12, 16]
         os: [ubuntu-20.04]
         toxenv: [django32]
     env:
@@ -47,6 +48,7 @@ jobs:
         shell: bash
         env:
           TESTNAME: js
+          NODE: ${{ matrix.node }}
           TARGETS: "requirements.js validate_js"
       - name: test i18n
         run: ./.github/scripts/testing.sh
@@ -59,12 +61,14 @@ jobs:
         shell: bash
         env:
           TESTNAME: acceptance
+          NODE: ${{ matrix.node }}
           TARGETS: "requirements.a11y migrate requirements.js static accept"
       - name: test python
         run: ./.github/scripts/testing.sh
         shell: bash
         env:
           TESTNAME: test-python
+          NODE: ${{ matrix.node }}
           TARGETS: "requirements.js static test_python"
       - name: code cov
         run: codecov --disable pycov

npm-post-install.sh

@@ -20,7 +20,8 @@ done
 # pre-compile the pattern library to improve sass compilation performance
 if [ ! -f ${PATTERN_LIBRARY_SASS_PATH}/edx-pattern-library-ltr-compiled.scss ]; then
   echo "Pre-compiling edX pattern library..."
-  ${NPM_BIN}/node-sass ${PATTERN_LIBRARY_SASS_PATH}/edx-pattern-library-ltr.scss ${PATTERN_LIBRARY_SASS_PATH}/edx-pattern-library-ltr-compiled.scss
+  ${NPM_BIN}/sass ${PATTERN_LIBRARY_SASS_PATH}/edx-pattern-library-ltr.scss
+  ${NPM_BIN}/sass ${PATTERN_LIBRARY_SASS_PATH}/edx-pattern-library-ltr-compiled.scss
   echo "Done compiling."
 else
   echo "edX pattern library already compiled."