From 09dac9019b6e6e4096041be538c885c90cc8ae4b Mon Sep 17 00:00:00 2001 From: saeedbashir Date: Fri, 18 Aug 2023 09:13:11 +0500 Subject: [PATCH] refactor: address review feedback --- Source/DiscoveryWebViewHelper.swift | 2 +- Source/NewCourseDashboardViewController.swift | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Source/DiscoveryWebViewHelper.swift b/Source/DiscoveryWebViewHelper.swift index 5f48e01ce..c98609882 100644 --- a/Source/DiscoveryWebViewHelper.swift +++ b/Source/DiscoveryWebViewHelper.swift @@ -96,7 +96,7 @@ class DiscoveryWebViewHelper: NSObject { } } - let offSet = container.view.viewWithTag(FakeStatusBarViewTag)?.frame.size.height ?? 0 + let offSet = container.view.viewWithTag(statuBarViewTag)?.frame.size.height ?? 0 titleView.snp.remakeConstraints { make in make.top.equalTo(contentView).offset(offSet) make.trailing.equalTo(contentView) diff --git a/Source/NewCourseDashboardViewController.swift b/Source/NewCourseDashboardViewController.swift index 9fb9f1e35..e44259bf6 100644 --- a/Source/NewCourseDashboardViewController.swift +++ b/Source/NewCourseDashboardViewController.swift @@ -8,7 +8,8 @@ import UIKit -let FakeStatusBarViewTag: Int = 123454321 +// view used at the exact same location of status bar in case of hidden navbar +let statuBarViewTag: Int = 123454321 public protocol NewCourseDashboardViewControllerDelegate: AnyObject { func showCourseDates(bannerInfo: DatesBannerInfo?, delegate: CourseOutlineTableController?) @@ -604,17 +605,17 @@ public extension UIViewController { func setStatusBar(inside contentView: UIView? = nil, color: UIColor) { let overView: UIView - if let contentView = contentView, let taggedView = contentView.viewWithTag(FakeStatusBarViewTag) { + if let contentView = contentView, let taggedView = contentView.viewWithTag(statuBarViewTag) { overView = taggedView } else if contentView != nil { overView = UIView() - overView.tag = FakeStatusBarViewTag + overView.tag = statuBarViewTag contentView?.addSubview(overView) - } else if let taggedView = view.viewWithTag(FakeStatusBarViewTag) { + } else if let taggedView = view.viewWithTag(statuBarViewTag) { overView = taggedView } else { overView = UIView() - overView.tag = FakeStatusBarViewTag + overView.tag = statuBarViewTag view.addSubview(overView) }