From f319b7bdcbb4c683320abddb607002665831eb61 Mon Sep 17 00:00:00 2001 From: Muhammad Umer Date: Wed, 4 Oct 2023 14:59:48 +0100 Subject: [PATCH] chore: update constraints on header view (#1805) --- Source/CourseDashboardHeaderView.swift | 7 +++++-- Source/NewCourseDashboardViewController.swift | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Source/CourseDashboardHeaderView.swift b/Source/CourseDashboardHeaderView.swift index 07f70c1c8..d17d1091e 100644 --- a/Source/CourseDashboardHeaderView.swift +++ b/Source/CourseDashboardHeaderView.swift @@ -309,8 +309,9 @@ class CourseDashboardHeaderView: UIView { } if bannerInfo != nil { - datesBannerView.removeFromSuperview() - containerView.addSubview(datesBannerView) + if !containerView.subviews.contains(datesBannerView) { + containerView.addSubview(datesBannerView) + } datesBannerView.snp.remakeConstraints { make in make.top.equalTo(bottomContainer.snp.bottom).offset(StandardVerticalMargin) @@ -318,6 +319,8 @@ class CourseDashboardHeaderView: UIView { make.trailing.equalTo(containerView) } bottomContainer = datesBannerView + } else { + datesBannerView.removeFromSuperview() } tabbarView.snp.remakeConstraints { make in diff --git a/Source/NewCourseDashboardViewController.swift b/Source/NewCourseDashboardViewController.swift index 413acd01a..6b25f53c4 100644 --- a/Source/NewCourseDashboardViewController.swift +++ b/Source/NewCourseDashboardViewController.swift @@ -153,7 +153,7 @@ class NewCourseDashboardViewController: UIViewController, InterfaceOrientationOv make.top.equalTo(safeTop) make.leading.equalTo(contentView) make.trailing.equalTo(contentView) - make.height.lessThanOrEqualTo(StandardVerticalMargin * 100) + make.height.lessThanOrEqualTo(StandardVerticalMargin * 120) } container.snp.remakeConstraints { make in