Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Initial Maintenance for some Axim Repos #850

Closed
4 of 7 tasks
feanil opened this issue Aug 18, 2023 · 13 comments
Closed
4 of 7 tasks

Do Initial Maintenance for some Axim Repos #850

feanil opened this issue Aug 18, 2023 · 13 comments
Assignees

Comments

@feanil
Copy link
Contributor

feanil commented Aug 18, 2023

Axim is taking on the maintenance for the following repositories. As a part of taking this on, we need to perform the initial maintenance tasks as defined in our docs: https://docs.openedx.org/en/latest/developers/how-tos/maintain-a-repo.html

Tasks

  • Do any initial tasks that have not yet been done as defined by the How-To

Relevant Repos

Acceptance Criteria

  • All initial maintenance has been complete.
  • We've confirmed that all new repos are making automated PRs and correctly tagging the @axim-aximprovements team.
@salman2013 salman2013 self-assigned this Aug 24, 2023
@salman2013
Copy link

@feanil Just for confirmation, in initial maintenance we need to do the first page maintenance things in https://docs.openedx.org/en/latest/developers/how-tos/maintain-a-repo.html. ? although we also have ongoing maintainer tasks.

@salman2013
Copy link

@feanil For this repository, as there is no python code file and there is no .github/workflows/upgrade-python-requirements.yml so how we will tag the reviewer?

@salman2013
Copy link

@feanil how can we find the owner of a package/component like
owner: "group:openedx-event-sink-clickhouse-maintainers"
I discussed this with BOM squad they mentioned they have an internal document available for all this information, Can you confirm do we have the same sheet or any other document?

@feanil
Copy link
Contributor Author

feanil commented Aug 29, 2023

@feanil Just for confirmation, in initial maintenance we need to do the first page maintenance things in https://docs.openedx.org/en/latest/developers/how-tos/maintain-a-repo.html. ? although we also have ongoing maintainer tasks.

Correct, for the repositories listed, we'll want to do ongoing maintenance but we need to do all the initial work for them as well before the team can do the on-going maintenance going forward.

@feanil For this repository, as there is no python code file and there is no .github/workflows/upgrade-python-requirements.yml so how we will tag the reviewer?

For the openedx-aspects repo, since it doesn't have any python code, we don't need to setup python requirements updates for it now. @bmtcril can you let us know if and when this has python requirements in the future if it should be managed by the Aximprovements team?

@feanil how can we find the owner of a package/component like owner: "group:openedx-event-sink-clickhouse-maintainers" I discussed this with BOM squad they mentioned they have an internal document available for all this information, Can you confirm do we have the same sheet or any other document?

For any group in a catalog file, it refers to a github team, so in this case the openedx-event-sink-clickhouse-maintainers github team.

@bmtcril
Copy link
Contributor

bmtcril commented Aug 29, 2023

Yep, that repo is just housing docs and cross-repository issues for the project so shouldn't need anything.

@salman2013
Copy link

@feanil The repo like tutor-contrib-aspects which already has done initial maintenance but the owner in catalog.yaml file is not axim so should i update that? like following like
owner: group:openedx/cc-analytics?
https://github.com/openedx/tutor-contrib-aspects/blob/d6d9d59912f3fdaf3954819935b3f6a5393e2596/catalog-info.yaml#L25

@feanil
Copy link
Contributor Author

feanil commented Sep 5, 2023

@salman2013 looking closer at this, I think it's fine to leave the owner as is. I believe @bmtcril plans on managing these via the analytics CCs rather than the axim team directly.

@bmtcril
Copy link
Contributor

bmtcril commented Sep 6, 2023

Yeah whenever we get around to getting the github groups up to where we want them to be a few of those repos should be getting maintained by the analytics group.

@salman2013
Copy link

tutor-contrib-aspects

This repo has already covered all initial maintenance points

openedx-aspects

This repo has already covered all initial maintenance points

openedx-event-sink-clickhouse

Done with it but don't have merging rights.

event-routing-backends

Done with it but don't have merging rights.

aspects-dbt

This repo has already covered all initial maintenance points

xapi-db-load

Done and merged

opaque-keys

Done and merged

@bmtcril
Copy link
Contributor

bmtcril commented Sep 14, 2023

Thanks @salman2013 I've merged the openedx-event-sink-clickhouse PRs. Aximprovements should have wrtie on that repo, let me know if it's still an issue.

@feanil
Copy link
Contributor Author

feanil commented Sep 19, 2023

@salman2013 what's left for this ticket?

@salman2013
Copy link

@feanil This is the last PR which i have fixed but needs to merge from the owner side, otherwise, all things have been done.

openedx/event-routing-backends#343

@feanil
Copy link
Contributor Author

feanil commented Sep 20, 2023

Awesome, I've just merged that one so this should be all set.

@feanil feanil closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

No branches or pull requests

3 participants