From 5b89915d82c25289e9af79e8c4588c126b71c0e6 Mon Sep 17 00:00:00 2001
From: Irtaza Akram <irtaza.akram@arbisoft.com>
Date: Mon, 8 Apr 2024 16:36:01 +0500
Subject: [PATCH] fix: dependencies

---
 .github/workflows/ci.yml | 1 -
 Makefile                 | 4 ++++
 requirements/test.txt    | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index bbbe7e7..3347c06 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -12,7 +12,6 @@ jobs:
     name: Tests
     runs-on: ${{ matrix.os }}
     strategy:
-      fail-fast: false
       matrix:
         os: [ubuntu-20.04]
         python-version: ['3.8', '3.11', '3.12']
diff --git a/Makefile b/Makefile
index 8c07546..eada5b9 100644
--- a/Makefile
+++ b/Makefile
@@ -63,6 +63,10 @@ upgrade: $(COMMON_CONSTRAINTS_TXT)  ## update the requirements/*.txt files with
 	# Let tox control the Django version for tests
 	sed '/^[dD]jango==/d' requirements/test.txt > requirements/test.tmp
 	mv requirements/test.tmp requirements/test.txt
+	# Also lets tox control DRF version
+	sed '/^[dD]jangorestframework==/d' requirements/test.txt > requirements/test.tmp
+	mv requirements/test.tmp requirements/test.txt
+
 
 quality: ## check coding style with pycodestyle and pylint
 	tox -e quality
diff --git a/requirements/test.txt b/requirements/test.txt
index 29f0711..209e9b2 100644
--- a/requirements/test.txt
+++ b/requirements/test.txt
@@ -77,7 +77,7 @@ django-waffle==4.1.0
     #   edx-django-utils
     #   edx-drf-extensions
     #   edx-toggles
-djangorestframework==3.15.1
+
     # via
     #   -r requirements/base.in
     #   drf-jwt