Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cs_comments_service on Ubuntu 24.04 #434

Closed
2 tasks
Tracked by #377
feanil opened this issue Aug 14, 2024 · 0 comments · Fixed by #435
Closed
2 tasks
Tracked by #377

Test cs_comments_service on Ubuntu 24.04 #434

feanil opened this issue Aug 14, 2024 · 0 comments · Fixed by #435
Labels
maintenance Routine upkeep necessary for the health of the platform

Comments

@feanil
Copy link
Contributor

feanil commented Aug 14, 2024

This repository is using Ubuntu 20.04 for testing. That version of Ubuntu will be out of support before Teak. Therefore this repo needs to be updated to testing with Ubuntu 24.04 before Sumac is cut to allow everyone sufficient time to switch to the new version.

Update this repository to test with Ubuntu 24.04 so that we can make the switch.

  • Tests are run and passing on Ubuntu 20.04 and 24.04
  • If major changes were needed and this is a library, a new version is published to PyPI or NPM

Note: In some cases, it may not make sense to test with both the old and the new version. For example, if the workflow is running linting or publishing to a package manager. In these cases, simply update the workflow to run on the newer version or opt to set it to ubuntu-latest instead if it doesn't matter what version it's running on. If you're unsure, reach out to the maintenance working group in #wg-maintenance in slack for guidance.

Known affected workflow files:

  • .github/workflows/ci.yml
@feanil feanil added the maintenance Routine upkeep necessary for the health of the platform label Aug 14, 2024
@feanil feanil mentioned this issue Aug 14, 2024
Closed
feanil added a commit that referenced this issue Sep 9, 2024
@feanil
build: Switch to ubuntu-latest for builds
506fd1c 
This code does not have any dependencies that are specific to any specific
version of ubuntu.  So instead of testing on a specific version and then needing
to do work to keep the versions up-to-date, we switch to the ubuntu-latest
target which should be sufficient for testing purposes.

This work is being done as a part of openedx/platform-roadmap#377

closes #434
@feanil feanil mentioned this issue Sep 9, 2024
Merged
@feanil feanil closed this as completed in ce71c39 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Routine upkeep necessary for the health of the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Switch to ubuntu-latest for builds openedx/cs_comments_service
1 participant
@feanil