Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: devstack settings #448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

regisb
Copy link

@regisb regisb commented Sep 12, 2024

Description:

Plugins may have a "devstack" setting, and this was not documented (as far as I know). I was bitten by this as I was trying to override settings in a plugin, and my settings were being overridden by devstack settings.

Plugins may have a "devstack" setting, and this was not documented (as far as I know). I was bitten by this as I was trying to override settings in a plugin, and my settings were being overridden by devstack settings.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 12, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @regisb!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-arch-bom. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@robrap
Copy link
Contributor

robrap commented Sep 12, 2024

Thanks @regisb. I’ll take this to our teams because:

  1. I’m not aware of us needing to do this for our plugin, and maybe that is just personal lack of awareness and maybe there are limited circumstances where this is required?
  2. 2U is helping with a DEPR around the devstack.py files. See this relevant comment: [DEPR] Devstack public-engineering#247 (comment). It would be nice to understand how this all fits in with the plan.

That said, I understand your intent is simply to get the docs in line with reality as a step.

@regisb
Copy link
Author

regisb commented Sep 12, 2024

I’m not aware of us needing to do this for our plugin, and maybe that is just personal lack of awareness and maybe there are limited circumstances where this is required?

We are currently working on a plugin (the new forum) that needs to override the COMMENTS_SERVICE_URL -- including in development. I did add the updated setting in common.py, but these values are immediately overridden by the values from edx-platform's devstack.py. A quick search revealed that the devstack settings are already used in the event routing backend (here).

2U is helping with a DEPR around the devstack.py files. See this relevant comment: openedx/public-engineering#247 (comment). It would be nice to understand how this all fits in with the plan.

I wasn't aware of that. I'll comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

3 participants