Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Ignore: [Bourbon] [Deprecation] rem is deprecated and will be removed in 5.0.0. #33571

Open
1 task
Tracked by #32888
DanielVZ96 opened this issue Oct 24, 2023 · 5 comments
Open
1 task
Tracked by #32888
Assignees

Comments

@DanielVZ96
Copy link
Contributor

This warning is appearing 165 times during provisioning. It clutters logs and hinders dev experience (#32888).

A decision needs to be made on whether all rem mixin usages are swapped with normal rems, or just ignore the warnings.

AC

  • The warnings stop cluttering logs
@devkhan
Copy link

devkhan commented Jul 13, 2024

assign me

@devkhan
Copy link

devkhan commented Jul 13, 2024

Since the warning is about deprecation, should we upgrade the js/npm package? And how do we ensure other dependencies don't break because of this?

@feanil
Copy link
Contributor

feanil commented Jul 15, 2024

@devkhan Since the rem from bourbon is being removed, we can't update the package until after we stop using the feature that is going to be removed. If you're going to take on this ticket, I suggest you figure out how to switch from the bourbon rem function to the normal rem bulit into modern CSS. To ensure we don't break anything you'll have to do visual spot checks of the UIs that use the relevant CSS.

@devkhan
Copy link

devkhan commented Jul 22, 2024

@feanil I think I got confused by your statement there. There is a rem in Bourbon v4, which is for converting px to rem units. But there is a rem function built into modern CSS (which is very recent), but it's for calculating the remainder (like % in python), and is completely different from the rem and em units used in CSS.

I think the solution will be to replace bourbon's rem with plain rem units, e.g. rem(24) -> '24rem'. Bourbon also suggests the same thing in it's migration guide.

Let me know if I'm on the right track and I can get started on that. Although, this very likely can have consequences in terms of UI (as font sizes units are changed). I think it should not cause any issues, but I'm not sure.

@feanil
Copy link
Contributor

feanil commented Jul 22, 2024

@devkhan correct, moving from the rem function to the standard rem unit and then visually checking UIs to make sure we didn't cause major issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants