Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestGetCourseUserPartitions tests #35028

Open
robrap opened this issue Jun 24, 2024 · 4 comments
Open

Fix flaky TestGetCourseUserPartitions tests #35028

robrap opened this issue Jun 24, 2024 · 4 comments
Assignees

Comments

@robrap
Copy link
Contributor

robrap commented Jun 24, 2024

Following the old Flaky Test Process, I've deleted two flaky tests.

The deletion PR is #35029.

The following tests were deleted:

Notes/Questions:

Failure 1:

=========================== short test summary info ============================
FAILED xmodule/partitions/tests/test_partitions.py::TestGetCourseUserPartitions::test_enrollment_track_partition_not_added_if_conflict - AssertionError: assert 1 == 2
 +  where 2 = len([UserPartition(id=0, name='Mock Partition', description='for testing purposes', groups=[Group(id=0, name='Group 1'), G...serPartitionScheme object at 0x7f3198774dd0>, parameters={'course_id': 'course-v1:org_0+course_0+run_0'}, active=True)])
==== 1 failed, 1487 passed, 170 skipped, 1572 warnings in 229.69s (0:03:49) ====

Failure 2:

=========================== short test summary info ============================
FAILED xmodule/partitions/tests/test_partitions.py::TestGetCourseUserPartitions::test_enrollment_track_partition_not_added_if_disabled - AssertionError: assert 1 == 2
 +  where 2 = len([UserPartition(id=0, name='Mock Partition', description='for testing purposes', groups=[Group(id=0, name='Group 1'), G...serPartitionScheme object at 0x7f6d54d9e9d0>, parameters={'course_id': 'course-v1:org_0+course_0+run_0'}, active=True)])
==== 1 failed, 1487 passed, 170 skipped, 1572 warnings in 229.98s (0:03:49) ====
@robrap robrap changed the title Deleted flaky TestGetCourseUserPartitions tests Fix flaky TestGetCourseUserPartitions tests Jun 24, 2024
robrap added a commit that referenced this issue Jun 24, 2024
The following TestGetCourseUserPartitions tests were deleted:
- test_enrollment_track_partition_not_added_if_conflict
- test_enrollment_track_partition_not_added_if_disabled

For details, see:
#35028
robrap added a commit that referenced this issue Jun 24, 2024
The following TestGetCourseUserPartitions tests were deleted:
- test_enrollment_track_partition_not_added_if_conflict
- test_enrollment_track_partition_not_added_if_disabled

For details, see:
#35028
@robrap
Copy link
Contributor Author

robrap commented Jun 25, 2024

FYI: @mariajgrimaldi @kdmccormick

@mariajgrimaldi
Copy link
Member

Hi, @robrap! Thanks for letting us know. I'll try to review what happened this week.

@robrap
Copy link
Contributor Author

robrap commented Jun 25, 2024

@mariajgrimaldi: I'm only guessing it is your PR because I didn't see any other changes, but I want to confirm it is just a guess.

@robrap
Copy link
Contributor Author

robrap commented Aug 5, 2024

@mariajgrimaldi: Friendly reminder about this ticket. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants