Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin elasticsearch and numpy in edx-platform #35126

Open
feanil opened this issue Jul 16, 2024 · 0 comments
Open

Unpin elasticsearch and numpy in edx-platform #35126

feanil opened this issue Jul 16, 2024 · 0 comments

Comments

@feanil
Copy link
Contributor

feanil commented Jul 16, 2024

There is a pin for elasticsearch<7.14.0 in the common_constraints file but it's not clear if this is a problem specific to course-discovery or a problem with edx-platform as well. Looking at the changelog, the biggest difference with the newer versions of the elastichsearch client is that you have to match the python client version to the corresponding elasticsearch client version or it will fail to startup.

Looking at the PR that added this change, it's not clear what exactly was the error being seen. After speaking with Jeremy at 2U, it looks like 2U is constrained with running elasticsearch 7.10 or opensearch and the newer version of the elasticsearch python library will break with both of those versions which explains the pin.

image

In the meantime, we'll have to pin numpy<2.0.0 no not block other upgrades because the current pin of elasticsearch depends on a function in numpy that is dropped in numpy 2.0.0.

Once the elasticsearch python package is at version 7.15.0 or greater or it has been removed from the platform, the numpy pin in requirements/constraints.txt can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant