Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent the model from fetching if the course_id is missing #1234

Closed
wants to merge 1 commit into from

Conversation

rijuma
Copy link
Member

@rijuma rijuma commented Sep 18, 2024

Description:

When the student-proctored-exam-container element is missing, the view tries to fetch a model with undefinedas an id since course_id is not set. This PR checks for its existence before fetching.

JIRA:

COSMO-472🔒

Pre-Merge Checklist:

  • Updated the version number in edx_proctoring/__init__.py and package.json if these changes are to be released.
  • Described your changes in CHANGELOG.rst
  • Confirmed Github reports all automated tests/checks are passing.
  • Approved by at least one additional reviewer.

Post-Merge:

  • Create a tag matching the new version number.

@rijuma
Copy link
Member Author

rijuma commented Sep 18, 2024

Closed. The views for the special exams from this repo are no longer used, so maybe will be removed in a future update.
For now we are going to remove their initialization in edx-platform.

@rijuma rijuma closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant