From 909e2d6cc9acd60c4d732b06c4dd43304f9f361a Mon Sep 17 00:00:00 2001 From: Brian Mesick Date: Mon, 23 Sep 2024 10:16:07 -0400 Subject: [PATCH] style: Update linting for newest pylint / edx-lint --- edx_event_bus_redis/internal/consumer.py | 2 +- pylintrc | 8 +++++--- pylintrc_tweaks | 3 +++ 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/edx_event_bus_redis/internal/consumer.py b/edx_event_bus_redis/internal/consumer.py index d55abb7..df161b8 100644 --- a/edx_event_bus_redis/internal/consumer.py +++ b/edx_event_bus_redis/internal/consumer.py @@ -186,7 +186,7 @@ def _consume_indefinitely(self): 'consumer_name': self.consumer_name, } - try: # pylint: disable=too-many-nested-blocks + try: logger.info(f"Running consumer for {run_context!r}") # How many errors have we seen in a row? If this climbs too high, exit with error. diff --git a/pylintrc b/pylintrc index 6dde361..469c401 100644 --- a/pylintrc +++ b/pylintrc @@ -64,7 +64,7 @@ # SERIOUSLY. # # ------------------------------ -# Generated by edx-lint version: 5.3.0 +# Generated by edx-lint version: 5.3.6 # ------------------------------ [MASTER] ignore = migrations @@ -259,6 +259,7 @@ enable = useless-suppression, disable = bad-indentation, + broad-exception-raised, consider-using-f-string, duplicate-code, file-ignored, @@ -376,6 +377,7 @@ max-parents = 7 max-attributes = 7 min-public-methods = 2 max-public-methods = 20 +max-positional-arguments = 10 [IMPORTS] deprecated-modules = regsub,TERMIOS,Bastion,rexec @@ -384,6 +386,6 @@ ext-import-graph = int-import-graph = [EXCEPTIONS] -overgeneral-exceptions = Exception +overgeneral-exceptions = builtins.Exception -# 46c7367b47aae914d36c17c49c676bffbc597fcd +# 4cac938bf878bc7ac3b1c8ca5875b8dc6e1088d4 diff --git a/pylintrc_tweaks b/pylintrc_tweaks index 7b6eb35..a131f62 100644 --- a/pylintrc_tweaks +++ b/pylintrc_tweaks @@ -9,3 +9,6 @@ disable+= django-not-configured, consider-using-with, bad-option-value, + +[DESIGN] +max-positional-arguments = 10