Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send events for missing courses #342

Closed
bmtcril opened this issue Aug 25, 2023 · 2 comments
Closed

Don't send events for missing courses #342

bmtcril opened this issue Aug 25, 2023 · 2 comments

Comments

@bmtcril
Copy link
Contributor

bmtcril commented Aug 25, 2023

Similar to #338 a course can be deleted from the platform, causing the course name to be sent as "Unknown Course":

event-routing-backends/event_routing_backends/helpers.py

Line 153 in 46ba27a

"display_name": "Unknown Course",

The course key will be correct, but downstream reporting may not be able to map it to any reliable values for course and block information. We should make an option to skip these, but leave it possible to send them in case of other xAPI use cases than reporting.
@bmtcril
Copy link
Contributor Author

bmtcril commented Oct 3, 2023

Actually I don't think we need a toggle for this, if we run into issues where people want deleted courses we can revisit.

@bmtcril
Copy link
Contributor Author

bmtcril commented Nov 3, 2023

I believe @Ian2012 fixed this in #355

@bmtcril bmtcril closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmtcril