Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event bus configuration causes events to be duplicated #410

Closed
bmtcril opened this issue Mar 29, 2024 · 2 comments
Closed

Event bus configuration causes events to be duplicated #410

bmtcril opened this issue Mar 29, 2024 · 2 comments
Labels
aspects v1 bug Report of or fix for something that isn't working as intended

Comments

@bmtcril
Copy link
Contributor

bmtcril commented Mar 29, 2024

Currently when both xapi and caliper keys are set in EVENT_TRACKING_BACKENDS and pointed to eventtracking.backends.event_bus.EventBusRoutingBackend each event that passes the whitelist will be sent to the same event bus stream twice.

The consumer does not discriminate about which backend it is handling, passing all events to any configured backend. This causes events to be transformed and sent twice. When batching, LRSs will reject the batch due to duplicate event ids. Off the top of my head we should either:

  • Have separate streams for each backend (better separation of concerns between xapi / caliper, requires a consumer for each) OR
  • Have one EVENT_TRACKING_BACKENDS for event-routing-backends and let it decide where to send things on event consumption (most efficient, but loses the ability to filter before sending and configure different filters for xapi and caliper?)

Neither of these are great, I'm open to other suggestions but this is a high priority issue.

@bmtcril bmtcril added aspects v1 bug Report of or fix for something that isn't working as intended labels Mar 29, 2024
@bmtcril
Copy link
Contributor Author

bmtcril commented Apr 29, 2024

@Ian2012 this was fixed, right?

@Ian2012
Copy link
Contributor

Ian2012 commented Apr 29, 2024

Yes, can be closed now.

@Ian2012 Ian2012 closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspects v1 bug Report of or fix for something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants