Allow event-routing-backends to be used when transforming non-openedx events #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
so that event-routing-backends can be dependency for non-edx-platform repos like openedx-completion-aggregator.
* Pulls the EVENT_TRACKING_BACKENDS configuration template into a utility method so it can be used by other apps. * Pulls allowed xAPI and Caliper events into settings to preserve changes * Adds a test
pomegranited
force-pushed
the
jill/fix-no-openedx
branch
from
0c90c3a
to
a415ee7
Compare
pomegranited
added a commit
to open-craft/openedx-completion-aggregator
that referenced
this pull request
Jun 12, 2024
…ings instead of global django.conf.settings
in class variable name and in a comment.
Refactors the transformer test classes to split the test functionality into two: * TransformersFixturesTestMixin -- for running the event fixture tests * TransformersTestMixin -- for running the ERB-specific event tests The fixtures file path constants have been moved to property methods so they can be overrideen when used outside of ERB.
This exception may occur when using ERB transformer test mixins because the fixture test files are not installed with this package.
13 tasks
Ian2012
approved these changes
Jun 14, 2024
…tings Initialize EVENT_TRACKING_BACKENDS_ALLOWED_XAPI_EVENTS and EVENT_TRACKING_BACKENDS_ALLOWED_CALIPER_EVENTS only if they aren't already initialized, and append our events to them. This allows other plugins to modify these settings too.
and fix coverage
pomegranited
force-pushed
the
jill/fix-no-openedx
branch
from
5685b3a
to
dc3a0f2
Compare
|
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Event Routing Backends is designed to be installed with edx-platform, and the code assumes this. But we want to use ERB outside of the platform too -- it contains event transform classes and test logic which is useful when transforming non-openedx events.
This PR:
See open-craft/openedx-completion-aggregator#205 for an example usage.
JIRA: FAL-3766 (private-ref)
Part of openedx/openedx-aspects#222
Merge deadline: end of June
Testing instructions:
See open-craft/openedx-completion-aggregator#205 for manual test instructions.
Merge checklist:
Post merge:
finished.