Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ENT-7309 Added budget category based page for learner credit #1003

Merged
merged 7 commits into from
Aug 3, 2023

Conversation

irfanuddinahmad
Copy link
Contributor

@irfanuddinahmad irfanuddinahmad commented Jul 10, 2023

Description: This PR adds a new learner credit page with subsections for Open Course and Executive Education

JIRA: ENT-7309

Reference:
image

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-7309 branch 2 times, most recently from 3342ef5 to eabf148 Compare July 18, 2023 07:02
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 91.22% and project coverage change: +0.05% 🎉

Comparison is base (21489d0) 83.19% compared to head (02a333f) 83.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
+ Coverage   83.19%   83.24%   +0.05%     
==========================================
  Files         397      400       +3     
  Lines        8645     8702      +57     
  Branches     1787     1797      +10     
==========================================
+ Hits         7192     7244      +52     
- Misses       1415     1420       +5     
  Partials       38       38              
Files Changed Coverage Δ
...earner-credit-management/MultipleBudgetsPicker.jsx 50.00% <50.00%> (ø)
...components/learner-credit-management/data/hooks.js 90.62% <66.66%> (-1.18%) ⬇️
.../learner-credit-management/MultipleBudgetsPage.jsx 81.81% <81.81%> (ø)
...omponents/learner-credit-management/BudgetCard.jsx 100.00% <100.00%> (ø)
...credit-management/LearnerCreditAllocationTable.jsx 94.44% <100.00%> (+0.69%) ⬆️
...components/learner-credit-management/data/utils.js 92.59% <100.00%> (+1.28%) ⬆️
src/utils.js 85.89% <100.00%> (+0.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-7309 branch 2 times, most recently from fabc7d6 to 00447df Compare July 18, 2023 10:53
@irfanuddinahmad irfanuddinahmad changed the title WIP feat: ENT-7309 Added budget category based page for learner credit feat: ENT-7309 Added budget category based page for learner credit Jul 19, 2023
@zamanafzal zamanafzal merged commit 8500f4d into master Aug 3, 2023
5 checks passed
@zamanafzal zamanafzal deleted the iahmad/ENT-7309 branch August 3, 2023 09:17
katrinan029 pushed a commit that referenced this pull request Aug 9, 2023
…1003)

* feat: ENT-7309 Added budget category-based page for learner credit

Co-authored-by: IrfanUddinAhmad <[email protected]>
Co-authored-by: zamanafzal <[email protected]>
katrinan029 pushed a commit that referenced this pull request Aug 9, 2023
…1003)

* feat: ENT-7309 Added budget category-based page for learner credit

Co-authored-by: IrfanUddinAhmad <[email protected]>
Co-authored-by: zamanafzal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants