fix: do not require change password to change reporting configuration

[jajjibhai008]

Description

Problem:
When we try to update a configuration report then the password is required even if I did not want to update it.

Solution:
I make the password field conditionally required while updating a report.

For all changes

• Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

• Ensure to attach screenshots
• Ensure to have UX team confirm screenshots

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (a209dd0) 83.24% compared to head (ea6fba3) 83.29%.

❗ Current head ea6fba3 differs from pull request most recent head af86f42. Consider uploading reports for the commit af86f42 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
+ Coverage   83.24%   83.29%   +0.04%     
==========================================
  Files         398      398              
  Lines        8649     8649              
  Branches     1791     1791              
==========================================
+ Hits         7200     7204       +4     
+ Misses       1411     1407       -4     
  Partials       38       38              

Impacted Files	Coverage Δ
...components/ReportingConfig/ReportingConfigForm.jsx	85.57% <100.00%> (+3.84%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bilaltahir21]

I think it would be better to use the existing variable requiredFields to check for password, it would keep validation logic in one place.

Can we add some tests to check password checkbox scenario? It would be helpful in future if anything in related logic changes.

[jajjibhai008]

I think it would be better to use the existing variable requiredFields to check for password, it would keep validation logic in one place.

Can we add some tests to check password checkbox scenario? It would be helpful in future if anything in related logic changes.

I think in our case we are making password and PGP key conditionally required so placing them in required fields will make the logic more complex of making fields conditionally required. So, that is why I choose this way.

I have added a test case of it too.