Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace useWindowSize with Paragon's useWindowSize #1006

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

katrinan029
Copy link
Contributor

Description

The useWindowSize hook in admin portal was added to Paragon, and the Paragon component includes tests. We should remove our copy and use that one.

Solution

Replace useWindowSize in admin portal, and replace with the one from Paragon as well as removing tests for useWindowSize.

JIRA

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 requested a review from a team July 11, 2023 19:59
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (f0ea4b0) 83.26% compared to head (aa0dea9) 83.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
- Coverage   83.26%   83.24%   -0.02%     
==========================================
  Files         399      398       -1     
  Lines        8659     8649      -10     
  Branches     1792     1791       -1     
==========================================
- Hits         7210     7200      -10     
  Misses       1411     1411              
  Partials       38       38              
Impacted Files Coverage Δ
src/components/IconWithTooltip/index.jsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marlonkeating marlonkeating self-requested a review July 11, 2023 20:17
@katrinan029 katrinan029 merged commit a209dd0 into master Jul 11, 2023
3 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ENT-4110 branch July 11, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants