Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sort enterprise enrollments ordering by default on last_activity_date #1008

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

zamanafzal
Copy link
Member

@zamanafzal zamanafzal commented Jul 13, 2023

sort enterprise enrollments ordering by default on last_activity_date

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0c787e3) 83.18% compared to head (5332388) 83.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1008   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files         397      397           
  Lines        8639     8639           
  Branches     1787     1787           
=======================================
  Hits         7186     7186           
  Misses       1415     1415           
  Partials       38       38           
Impacted Files Coverage Δ
src/components/EnrollmentsTable/index.jsx 83.33% <ø> (ø)
src/components/TableComponent/index.jsx 67.34% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there is a typo in the PR description.
Other than that LGTM 👍

@zamanafzal zamanafzal merged commit 71de4bc into master Jul 17, 2023
@zamanafzal zamanafzal deleted the zafzal/ENT7330 branch July 17, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants