Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: portal appearance tab appears by default #1010

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

emrosarioa
Copy link
Contributor

When clicking Settings, the "Portal Appearance" tab is now the default, and the corresponding tab is furthest to the left.
Screenshot 2023-07-27 at 9 51 44 AM

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (70536da) 83.18% compared to head (30545f9) 83.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1010   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files         397      397           
  Lines        8639     8639           
  Branches     1787     1787           
=======================================
  Hits         7186     7186           
  Misses       1415     1415           
  Partials       38       38           
Files Changed Coverage Δ
src/components/settings/SettingsTabs.jsx 90.32% <100.00%> (ø)
src/components/settings/data/constants.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just 1 minor test-related comment.

@@ -39,7 +39,7 @@ describe('<SettingsPage />', () => {
it('Redirects to access tab when no param given', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename the test case to mention "appearance tab" instead.

@emrosarioa emrosarioa merged commit 88357d6 into master Jul 27, 2023
5 checks passed
@emrosarioa emrosarioa deleted the ea/ent-7433 branch July 27, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants