Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add i18n_extract to package.json for openedx-translations #1013

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

OmarIthawi
Copy link
Member

This step is needed for openedx-translations repo to extract source files.

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

This fixes the error below:

make extract_translations
....
npm run-script i18n_extract
npm ERR! Missing script: "i18n_extract"
make: *** [Makefile:48: i18n.extract] Error 1
Error: Process completed with exit code 2.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

This step is needed for openedx-translations repo to extract source
files.

This contribution is part of the [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) which is sparked by the [Translation Infrastructure update OEP-58](https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html#specification).
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (88357d6) 83.18% compared to head (431e5d1) 83.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1013   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files         397      397           
  Lines        8639     8639           
  Branches     1787     1787           
=======================================
  Hits         7186     7186           
  Misses       1415     1415           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril merged commit d24bd61 into openedx:master Aug 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants