fix: ensure lint returns error on failure #1014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-smith-tcril
changed the title
Coupon.test.jsx
brian-smith-tcril
added a commit
to brian-smith-tcril/frontend-app-publisher
that referenced
this pull request
Aug 1, 2023
After making openedx/frontend-app-admin-portal#1014, I did a full search of the org for `; npm run` and ended up here. This PR ensures the CI will fail when eslint fails.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1014 +/- ##
=======================================
Coverage 83.18% 83.18%
=======================================
Files 397 397
Lines 8639 8639
Branches 1787 1787
=======================================
Hits 7186 7186
Misses 1415 1415
Partials 38 38 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this was failing lint when reviewing #1013. The CI was running but the lint command in
package.jsonwas written in a way that wouldn't fail CI on lint failure. This PR updates thepackage.jsonto fail CI when lint fails, and fixes the lint errors inCoupon.test.jsx(by runningnpm run lint:fix)