Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ENT-7445 Added support for picking first active subsidy when multiple available #1015

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

irfanuddinahmad
Copy link
Contributor

@irfanuddinahmad irfanuddinahmad commented Aug 1, 2023

Description: This PR adds support for picking the first active subsidy when multiple are available.

JIRA: ENT-7445

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b39c87a) 83.18% compared to head (4bdf5db) 83.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1015   +/-   ##
=======================================
  Coverage   83.18%   83.19%           
=======================================
  Files         397      397           
  Lines        8641     8645    +4     
  Branches     1787     1787           
=======================================
+ Hits         7188     7192    +4     
  Misses       1415     1415           
  Partials       38       38           
Files Changed Coverage Δ
...omponents/EnterpriseSubsidiesContext/data/hooks.js 95.65% <100.00%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@emrosarioa emrosarioa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the change to use is_active from the subsidy response!

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-7445 branch 2 times, most recently from b4da66c to 45f5320 Compare August 2, 2023 10:15
@irfanuddinahmad irfanuddinahmad merged commit 21489d0 into master Aug 2, 2023
5 checks passed
@irfanuddinahmad irfanuddinahmad deleted the iahmad/ENT-7445 branch August 2, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants